[OpenJDK 2D-Dev] RFR: 8256321: Some "inactive" color profiles use the wrong profile class
Prasanta Sadhukhan
psadhukhan at openjdk.java.net
Thu Nov 19 11:01:06 UTC 2020
On Tue, 17 Nov 2020 18:27:06 GMT, Victor Dyakov <vdyakov at openjdk.org> wrote:
>> The implementation of ICC_Profile tries to defer loading the data of the color profile, and it uses some predefined values for some profile properties for the standard profiles like sRGB, PYCC, etc. If the application requests profile data then the ICC_Profile class activates the profile and uses properties from that data.
>>
>> Deferring mechanism for all profiles was added in JDK-6793818, but unfortunately, the color profile class was hardcoded incorrectly "CLASS_DISPLAY" for all profiles. However, the "CIEXYZ.pf" and "PYCC.pf" profiles should use "CLASS_COLORSPACECONVERSION".
>>
>> Later the color "profiles/xxx.pf" were replaced in the JDK, and the actual type of the "CIEXYZ.pf" was changed to the "CLASS_ABSTRACT", but the deferring mechanism still uses "CLASS_DISPLAY".
>>
>> As a result of this bug, the color profile reports different values before/after activations.
>
> @prsadhuk please review this fix
It will be good to know where, in spec or any link, it is mentioned to use CLASS_ABSTRACT/CLASS_COLORSPACECONVERSION instead of CLASS_DISPLAY?
-------------
PR: https://git.openjdk.java.net/jdk/pull/1211
More information about the 2d-dev
mailing list