[OpenJDK 2D-Dev] RFR: 8231231: The printing result is different from the case instruction
Sergey Bylokhov
serb at openjdk.java.net
Thu Oct 22 08:44:11 UTC 2020
On Wed, 21 Oct 2020 11:50:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:
> Please review a manual printing test failure where the instructions is not matching the printing result
> as the labels which are present in the test instruction frame is cut off in printed result due to margin not being accounted for,
> as the labels in the test instruction is fully left aligned starting from 0.
> Fixed by adding some spaces before labels and
> for other labels drawn through drawChars, modified to draw the labels from coordinate 20 instead of 0 to allow labels being printed in the paper and not get cutoff by margin.
> Also, the Print instruction is brought to top and 1st label is brought to bottom (SOUTH position in BorderLayout) as 1st label is in JScrollPane so to account for top margin cutoff, brought it lower so that those labels does not get cut off.
Probably we should not use some hardcoded values but use some paper related insets? Don't we need to update the public int print(Graphics graphics) instead and scale the frame to the paper, or just translate the graphics passed to print() before passing it to this.paint()?
-------------
PR: https://git.openjdk.java.net/jdk/pull/780
More information about the 2d-dev
mailing list