[OpenJDK 2D-Dev] RFR: 8231231: The printing result is different from the case instruction

[Phil Race]

On Wed, 21 Oct 2020 11:50:37 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> Please review a manual printing test failure where the instructions is not matching the printing result 
> as the labels which are present in the test instruction frame is cut off in printed result due to margin not being accounted for, 
> as the labels in the test instruction is fully left aligned starting from 0.
> Fixed by adding some spaces before labels and 
> for other labels drawn through drawChars, modified to draw the labels from coordinate 20 instead of 0 to allow labels being printed in the paper and not get cutoff by margin.
> Also, the Print instruction is brought to top and 1st label is brought to bottom (SOUTH position in BorderLayout) as 1st label is in JScrollPane so to account for top margin cutoff, brought it lower so that those labels does not get cut off.

test/jdk/java/awt/print/bug8023392/bug8023392.java line 77:

> 75:             setLayout(new BorderLayout());
> 76:             label1 = new JLabel("  2a) a b c d e" +
> 77:                     "                         ");

See my general comment - this needs to be changed.

test/jdk/java/awt/print/bug8023392/bug8023392.java line 49:

> 47: public class bug8023392 extends Applet {
> 48:     static final String[] instructions = {
> 49:         "Please select variable radiobutton in applet.",

why?  And the text reads oddly,  I think you mean
"Please select the Radio Button for applet size labeled "sariable"  in the test harness window"
but still, why ??

-------------

PR: https://git.openjdk.java.net/jdk/pull/780