[OpenJDK 2D-Dev] RFR: 8231231: The printing result is different from the case instruction [v3]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Tue Oct 27 07:50:30 UTC 2020


> Please review a manual printing test failure where the instructions is not matching the printing result 
> as the labels which are present in the test instruction frame is cut off in printed result due to margin not being accounted for, 
> as the labels in the test instruction is fully left aligned starting from 0.
> Fixed by adding some spaces before labels and 
> for other labels drawn through drawChars, modified to draw the labels from coordinate 20 instead of 0 to allow labels being printed in the paper and not get cutoff by margin.
> Also, the Print instruction is brought to top and 1st label is brought to bottom (SOUTH position in BorderLayout) as 1st label is in JScrollPane so to account for top margin cutoff, brought it lower so that those labels does not get cut off.

Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:

  Translate the graphics context origin to x,y coordinate of paper's imageable area

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/780/files
  - new: https://git.openjdk.java.net/jdk/pull/780/files/89d21206..96c1c7a8

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=780&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=780&range=01-02

  Stats: 17 lines in 2 files changed: 2 ins; 1 del; 14 mod
  Patch: https://git.openjdk.java.net/jdk/pull/780.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/780/head:pull/780

PR: https://git.openjdk.java.net/jdk/pull/780


More information about the 2d-dev mailing list