[OpenJDK 2D-Dev] RFR: 8234393 [macos] printing ignores printer tray

[Vipin Mv1]

Hi,

May I ask for a status on this please.			
 						

-----Vipin Mv1/India/IBM wrote: -----
To: Philip Race <philip.race at oracle.com>
From: Vipin Mv1/India/IBM
Date: 08/31/2020 05:52PM
Cc: 2d-dev at openjdk.java.net
Subject: Re: [EXTERNAL] Re: [OpenJDK 2D-Dev] RFR: 8234393 [macos] printing ignores printer tray

Hi Philip,

Thanks for the review comments. The testcase test/jdk/java/awt/print/PrinterJob/TestMediaTraySelection.java seems to be intended to test only the MediaTray functionality. Also, it doesn't seems to have anything that is Linux specific.

Rather than having a new testcase wouldn't it be fine to have os.family == "mac" change alone to the existing one.?

Regarding the testing, the patch was already tested by our customer using a multi tray printer and was found to be working. Owing to WFH factor due to COVID19, multi tray printer is not accessible to us at this point of time.

May I request if the community can help us do further testing with the multi tray printer.

Thanks & Regards
Vipin MV

-----Philip Race <philip.race at oracle.com> wrote: -----
To: Vipin Mv1 <vipinmv1 at in.ibm.com>
From: Philip Race <philip.race at oracle.com>
Date: 08/30/2020 10:02PM
Cc: 2d-dev at openjdk.java.net
Subject: [EXTERNAL] Re: [OpenJDK 2D-Dev] RFR: 8234393 [macos] printing ignores printer tray

PS there is an existing manual regression test but it is currently 
geared towards Linux and in fact is set to run only on Linux
test/jdk/java/awt/print/PrinterJob/TestMediaTraySelection.java
So you still may find it easier to create a new test rather than modify 
this one to avoid breaking what it tests.

-phil


On 8/29/20, 11:10 AM, Philip Race wrote:
> PS, there's a test case in the bug. Seems like it could be used as the 
> basis for a manual regression test.
>
> Make sure you use @requires printer  as well as adding the manual and 
> headful keywords
> and next you'll have to check for an installed printer with multiple 
> trays
>
> -phil
>
> On 8/27/20, 11:36 AM, Philip Race wrote:
>> This looks reasonable but we need to test it first before approving it.
>>
>> -phil.
>>
>> On 8/27/20, 6:16 AM, Vipin Mv1 wrote:
>>> Hi,
>>>
>>> Please find below a patch for the following issue.
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8234393 
>>>
>>>
>>> http://cr.openjdk.java.net/~aleonard/8234393/webrev.00 
>>>
>>> Thanks&  Regards
>>> Vipin MV
>>>
>>>