[OpenJDK 2D-Dev] RFR: 8263984: Invalidate printServices when there are no printers

Jayathirth D V jdv at openjdk.java.net
Thu Apr 1 06:09:14 UTC 2021


On Tue, 23 Mar 2021 13:45:33 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

> When `getAllPrinterNames()` returns null, the list of `printServices` is assigned a new empty array without invalidating old services which were in the array before.
> 
> The old print services should be invalidated.

src/java.desktop/windows/classes/sun/print/PrintServiceLookupProvider.java line 159:

> 157:             for (int j=0; j < printServices.length; j++) {
> 158:                 if ((printServices[j] instanceof Win32PrintService) &&
> 159:                             (!printServices[j].equals(defaultPrintService))) {

Is this indentation right? I thought we always map newline additional conditions and not add extra indentation.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3151


More information about the 2d-dev mailing list