[OpenJDK 2D-Dev] RFR: 8264475: CopyArea ignores clip state in metal rendering pipeline [v3]

[Prasanta Sadhukhan]

On Thu, 1 Apr 2021 05:49:51 GMT, Jayathirth D V <jdv at openjdk.org> wrote:

>> In MTLBlitLoops.copyArea() we use standalone encoder which has no clip state information because of which we ignore clip parameters set in rect clip and shape clip. We need to query and use encoders from EncoderManager to honour clip states in copyArea.
>
> Jayathirth D V has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Comment update

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.m line 826:

> 824:             id<MTLRenderCommandEncoder> interEncoder =
> 825:                 [mtlc.encoderManager getTextureEncoder:interTexture
> 826:                                            isSrcOpaque:dstOps->isOpaque

Should it not be srcOps->isOpaque?

src/java.desktop/macosx/native/libawt_lwawt/java2d/metal/MTLBlitLoops.m line 854:

> 852:                             atIndex:MeshVertexBuffer];
> 853:             [finalEncoder setFragmentTexture:interTexture atIndex: 0];
> 854:             [finalEncoder drawPrimitives:MTLPrimitiveTypeTriangle vertexStart:0

Can't we reuse drawTex2Tex() for this snippet?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3283