[OpenJDK 2D-Dev] RFR: 8269223: -Xcheck:jni WARNINGs working with fonts on Linux [v4]

Phil Race prr at openjdk.java.net
Fri Aug 13 00:11:29 UTC 2021


On Thu, 12 Aug 2021 21:58:07 GMT, Phil Race <prr at openjdk.org> wrote:

>> Maxim Kartashev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Addressed PR comments
>>   
>>   1. Added CHECK_NULL() to awt_Component.cpp
>
> test/jdk/java/awt/font/JNICheck/FreeTypeScalerJNICheck.java line 29:
> 
>> 27:  * @summary Verifies that -Xcheck:jni issues no warnings from freetypeScaler.c
>> 28:  * @library /test/lib
>> 29:  * @key headful
> 
> What about this test is headful ?

oh you are getting metrics for a JFrame ? That's not going to exercise any new font code so is pointless except to make it so the test has to be headful.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4572


More information about the 2d-dev mailing list