[OpenJDK 2D-Dev] RFR: 8272863: Replace usages of Collections.sort with List.sort call in public java modules

Alexander Zvegintsev azvegint at openjdk.java.net
Tue Aug 24 11:51:26 UTC 2021


On Mon, 23 Aug 2021 21:01:48 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

> Collections.sort is just a wrapper, so it is better to use an instance method directly.

There are a bunch of calls to `Collections.sort()` without a comparator specified  (at least in java.desktop):

https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/java2d/Spans.java#L144
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/awt/DebugSettings.java#L278
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/sun/swing/text/TextComponentPrintable.java#L787
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/DefaultRowSorter.java#L1070
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/DefaultRowSorter.java#L1204
https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/GroupLayout.java#L2137

It is also a wrapper to `list.sort(null)`. 

Is there any reason to not touch them along with this fix?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5229


More information about the 2d-dev mailing list