[OpenJDK 2D-Dev] RFR: 8272878: JEP 381 cleanup: Remove unused Solaris code in sun.font.TrueTypeGlyphMapper

Daniel Gredler github.com+178883+gredler at openjdk.java.net
Mon Aug 30 11:19:25 UTC 2021


On Mon, 23 Aug 2021 22:05:13 GMT, Daniel Gredler <github.com+178883+gredler at openjdk.org> wrote:

> During the recent JEP 381 removal of Solaris code, a few Solaris-specific constants and private methods were left behind in sun.font.TrueTypeGlyphMapper. This PR removes these unused odds and ends.

I had initially wanted to keep this PR focused on a small, self-contained, fairly obvious change, since this is my first contribution to the project -- but I'm open to expanding the scope if I can get some direction.

It can be argued that many of the comments which mention Solaris still provide useful background information, e.g.:

https://github.com/openjdk/jdk/blob/739769c8fc4b496f08a92225a12d07414537b6c0/src/java.desktop/share/classes/sun/font/CompositeFont.java#L243

https://github.com/openjdk/jdk/blob/90cd2fa16458dcc3e36171fa4bf21f26bc92b168/src/java.desktop/share/classes/sun/font/StrikeCache.java#L81

https://github.com/openjdk/jdk/blob/c36755dedf1a0d7ce0aeadd401e0c70ff84185e7/src/java.desktop/share/classes/sun/font/TrueTypeFont.java#L744

There are some other comments that could more obviously be fixed without issues:

https://github.com/openjdk/jdk/blob/6765f902505fbdd02f25b599f942437cd805cad1/src/java.desktop/share/classes/sun/font/FontManagerFactory.java#L42

@prsadhuk @prrace How would you like me to proceed?

-------------

PR: https://git.openjdk.java.net/jdk/pull/5232


More information about the 2d-dev mailing list