[OpenJDK 2D-Dev] RFR: 8260695: The java.awt.color.ICC_Profile#getData/getData(int) are not thread safe [v2]
Sergey Bylokhov
serb at openjdk.java.net
Sat Feb 6 07:25:08 UTC 2021
> Both methods are implemented in a similar way.
> 1. Requests the size of the profile/tag data
> 2. Creates an array of the correct size
> 3. Requests the data and copy it to the array
>
> If the data will be changed concurrently between steps 2. and 3. then we will get a mismatch between the array and copied data.
>
> In the fix, all steps above are merged to just one step - return the data when requested.
Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:
- Merge branch 'master' into JDK-8260695
- cleanup
- Merge branch 'JDK-8260695' of https://github.com/mrserb/jdk into JDK-8260695
- Update LCMSProfile.java
- Update LCMSProfile.java
- Create MTGetData.java
- Initial fix
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/2330/files
- new: https://git.openjdk.java.net/jdk/pull/2330/files/162fde0c..a9347ae3
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=2330&range=01
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=2330&range=00-01
Stats: 15457 lines in 693 files changed: 9560 ins; 3448 del; 2449 mod
Patch: https://git.openjdk.java.net/jdk/pull/2330.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/2330/head:pull/2330
PR: https://git.openjdk.java.net/jdk/pull/2330
More information about the 2d-dev
mailing list