[OpenJDK 2D-Dev] RFR: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method [v6]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Wed Feb 17 15:08:59 UTC 2021


On Wed, 17 Feb 2021 14:20:47 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javdoc tag for NPE
>
> src/java.desktop/share/classes/java/awt/Graphics2D.java line 1205:
> 
>> 1203:      * user clip. Since this method intersects the specified shape
>> 1204:      * with the current clip, it will throw {@code NullPointerException} for a null shape
>> 1205:      * unless the user clip is also null.
> 
> Shall the text be re-wrapped?
> 
> I'm not sure if null should always be {@code null}, it's not used consistently. At the same time, two lines above it's “…with a {@code null} argument…”; it makes sense to make Javadoc consistent in this regard at least for one method.

ok .fair enough...done..

-------------

PR: https://git.openjdk.java.net/jdk/pull/2476


More information about the 2d-dev mailing list