[OpenJDK 2D-Dev] RFR: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method [v7]

Prasanta Sadhukhan psadhukhan at openjdk.java.net
Wed Feb 17 15:38:11 UTC 2021


On Wed, 17 Feb 2021 15:25:35 GMT, Alexey Ivanov <aivanov at openjdk.org> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   javadoc change
>
> src/java.desktop/share/classes/java/awt/Graphics2D.java line 1206:
> 
>> 1204:      * with the current clip, it will throw {@code NullPointerException}
>> 1205:      * for a null shape unless the user clip is also {@code null}.
>> 1206:      * So calling this method with a null argument is not recommended.
> 
> Since you're editing the javadoc for this method, wouldn't adding a couple `<p>` break up the description to make it clearer?
> 
> 1198     * <p>The <i>user clip</i> modified by this method is independent of the
> 1203     * user clip.
>          * <p>Since this method intersects the specified shape
> The rendered javadoc will have clear separation between different paragraphs and will facilitate scanning the method description.
> 
> Does it make any sense?

ok. sure...

-------------

PR: https://git.openjdk.java.net/jdk/pull/2476


More information about the 2d-dev mailing list