[OpenJDK 2D-Dev] RFR: 6206189: Graphics2D.clip specifies incorrectly that a 'null' is a valid value for this method [v9]

Alexey Ivanov aivanov at openjdk.java.net
Wed Feb 17 15:54:27 UTC 2021


On Wed, 17 Feb 2021 15:48:12 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>> The API doc for Graphics2D.clip(shape s) claims that passing a null argument would actually clear the existing clipping area, which is incorrect.
>> This statement is applicable only to G2D.setClip() and not for the clip() method. G2D.clip() would throw a NullPointerException when it encounters a null argument. 
>> Updated spec to rectify this.
>
> Prasanta Sadhukhan has updated the pull request incrementally with one additional commit since the last revision:
> 
>   javadoc change

src/java.desktop/share/classes/java/awt/Graphics2D.java line 1207:

> 1205:      * with the current clip, it will throw {@code NullPointerException}
> 1206:      * for a null shape unless the user clip is also {@code null}.
> 1207:      * So calling this method with a {@code null} argument is not recommended.

I wonder why not “{@code null} shape” at line 1206?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2476


More information about the 2d-dev mailing list