[OpenJDK 2D-Dev] RFR: 8196301: java/awt/print/PrinterJob/Margins.java times out

[Prasanta Sadhukhan]

On Thu, 18 Feb 2021 03:40:24 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

>>> Maybe @key printer is not being taken seriously during system setup which is why no real printer is being used.
>> 
>> That should be irrelevant. jtreg should only be invoking tests which do NOT have the printer keyword since the test job has this : keywords=headful & !printer which are handed directly to jtreg. In other words it is not filtering on whether there is actually a printer, but on whether the keyword is present.
>> 
>> So if this test is being invoked on tests which specify that then there's something badly wrong with jtreg or the harness is mangling it.
>> 
>> But I think this bug was filed back when this test was MISSING that keyword - it was added here 
>> http://hg.openjdk.java.net/jdk/client/rev/f13dba72a5ea
>> 
>> So likely you should be focused on the timing issue and not the file printers
>
>> That should be irrelevant. jtreg should only be invoking tests which do NOT have the printer keyword since the test job has this : keywords=headful & !printer which are handed directly to jtreg. In other words it is not filtering on whether there is actually a printer, but on whether the keyword is present.
>> 
>> So if this test is being invoked on tests which specify that then there's something badly wrong with jtreg or the harness is mangling it.
> 
> I have to change script to have keywords=headful & printer as it was not running this test in mach5 without it.

Since this is one of the few printer test which is automated, it will fail locally too if someone has "Print to PDF", "XPS" or "OneNote" printer as default since it will open up filedialog or app which will prevent the focus to be on "OK" button of pagedialog, so the fix is applicable locally too, so I would like this fix to be considered.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2598