[OpenJDK 2D-Dev] RFR: 8259042: Inconsistent use of general primitives loops

Phil Race prr at openjdk.java.net
Mon Jan 4 21:09:03 UTC 2021


On Mon, 4 Jan 2021 08:09:31 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> The java2d uses the primitives such as Blit loop for rendering differing things. Currently, not all possible variants of primitives are implemented, but it is possible to register some general loop that may produce the primitives for some specific src/comp/dst.
> 
> But we have some inconsistent here:
>  - Some primitives register themselves as a general loop but always return null in the makePrimitive() method
>  - Some primitives (which are not registered as general loops) return null or throw an error in the makePrimitive() method
> 
> After the fix:
>  - The primitive will be registered as a general primitive only if it has a meaningful makePrimitive method
>  - An attempt to call the makePrimitive for non registered general loop will cause an error
> 
> mach5 is green

Marked as reviewed by prr (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/1926


More information about the 2d-dev mailing list