[OpenJDK 2D-Dev] RFR: 6986863: ProfileDeferralMgr throwing ConcurrentModificationException [v5]
Sergey Bylokhov
serb at openjdk.java.net
Thu Jan 28 03:44:02 UTC 2021
On Wed, 27 Jan 2021 18:38:27 GMT, Alexander Zuev <kizune at openjdk.org> wrote:
>> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>>
>> - Merge branch 'master' into JDK-6986863
>> - Merge branch 'master' into JDK-6986863
>> - Update ProfileActivationDuringPropertyAccess.java
>> - Merge branch 'master' into JDK-6986863
>> - Merge branch 'master' into JDK-6986863
>> - Merge branch 'master' into JDK-6986863
>> - Merge branch 'master' into JDK-6986863
>> - Delete the DeferralMgr machinery
>> - Update ICC_Profile.java
>> - Wrong spec in ProfileDeferralInfo
>> - ... and 4 more: https://git.openjdk.java.net/jdk/compare/14522800...ecfc1ed8
>
> src/java.desktop/share/classes/sun/java2d/cmm/lcms/LCMSTransform.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2007, 2020, Oracle and/or its affiliates. All rights reserved.
>
> Review took so long that years here and in other headers of modified files needs to be updated.
Fixed.
> test/jdk/java/awt/color/ICC_ProfileRGB/MTMatrixAccess.java line 54:
>
>> 52: }
>> 53: try {
>> 54: rgb.getMatrix();
>
> What should happen when this method is called on profile that is not activated yet? Should you just check that it returns the non-null array of correct size?
This method always returns the array, only an exception can prevent that.
-------------
PR: https://git.openjdk.java.net/jdk/pull/1613
More information about the 2d-dev
mailing list