[OpenJDK 2D-Dev] RFR: 8263981: java.awt.image.ComponentSampleModel equals/hashcode use numBands twice

Aleksey Shipilev shade at openjdk.java.net
Mon Mar 22 16:01:54 UTC 2021


SonarCloud reports the problem in ComponentSampleModel.equals:
  Correct one of the identical sub-expressions on both sides of operator "&&"

...near "this.numBands == that.numBands". It is checked twice. hashCode also processes it twice.

-------------

Commit messages:
 - Update copyright line
 - JDK-8263981: java.awt.image.ComponentSampleModel equals/hashcode use numBands twice

Changes: https://git.openjdk.java.net/jdk/pull/3125/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3125&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-8263981
  Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3125.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3125/head:pull/3125

PR: https://git.openjdk.java.net/jdk/pull/3125


More information about the 2d-dev mailing list