[OpenJDK 2D-Dev] Integrated: 8263981: java.awt.image.ComponentSampleModel equals/hashcode use numBands twice

Aleksey Shipilev shade at openjdk.java.net
Wed Mar 24 07:04:42 UTC 2021


On Mon, 22 Mar 2021 15:55:16 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> SonarCloud reports the problem in ComponentSampleModel.equals:
>   Correct one of the identical sub-expressions on both sides of operator "&&"
> 
> ...near "this.numBands == that.numBands". It is checked twice. hashCode also processes it twice.

This pull request has now been integrated.

Changeset: cb776edf
Author:    Aleksey Shipilev <shade at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/cb776edf
Stats:     4 lines in 1 file changed: 0 ins; 3 del; 1 mod

8263981: java.awt.image.ComponentSampleModel equals/hashcode use numBands twice

Reviewed-by: serb, azvegint

-------------

PR: https://git.openjdk.java.net/jdk/pull/3125


More information about the 2d-dev mailing list