[OpenJDK 2D-Dev] RFR: 8266545: 8261169 broke Harfbuzz build with gcc 7 and 8 [v2]

[Thomas Stuefe]

On Thu, 6 May 2021 06:16:36 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Thomas Stuefe has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   switch off warning in build instead of fixing it
>
> FWIW, current jdk master builds fine with gcc 9.3.0. It fails with gcc 6.3.0 to me.
> 
> I am unaware of the policy of changing the Harfbuzz sources too. If we are changing the Harfbuzz sources, I prefer the multi-line form you did in Harfbuzz PR, though: https://github.com/harfbuzz/harfbuzz/pull/2973 -- it would also simplify the merge. 
> 
> But there is an alternative, disable the warning and then wait for Harfbuzz fix to drop:
> 
> 
> diff --git a/make/modules/java.desktop/lib/Awt2dLibraries.gmk b/make/modules/java.desktop/lib/Awt2dLibraries.gmk
> index ff5fa00c720..627aa51ebdf 100644
> --- a/make/modules/java.desktop/lib/Awt2dLibraries.gmk
> +++ b/make/modules/java.desktop/lib/Awt2dLibraries.gmk
> @@ -465,7 +465,7 @@ else
>  
>     HARFBUZZ_DISABLED_WARNINGS_gcc := type-limits missing-field-initializers strict-aliasing
>     HARFBUZZ_DISABLED_WARNINGS_CXX_gcc := reorder delete-non-virtual-dtor strict-overflow \
> -        maybe-uninitialized class-memaccess unused-result
> +        maybe-uninitialized class-memaccess unused-result extra
>     HARFBUZZ_DISABLED_WARNINGS_clang := unused-value incompatible-pointer-types \
>          tautological-constant-out-of-range-compare int-to-pointer-cast \
>          undef missing-field-initializers range-loop-analysis \

I changed the fix according to @shipilev suggestion. This avoids all the hassle of changing downstream HB sources.

@shipilev can we consider this as trivial?

-------------

PR: https://git.openjdk.java.net/jdk/pull/3873