<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<p>Any reviewer for this?<br>
</p>
<div class="moz-cite-prefix">On 09-Jul-20 1:10 PM, Prasanta
Sadhukhan wrote:<br>
</div>
<blockquote type="cite"
cite="mid:05a59b29-c359-58a0-daa2-e572e52d3e6b@oracle.com">
<meta http-equiv="content-type" content="text/html; charset=UTF-8">
<p>Hi All,</p>
<p>Please review a fix for an issue where "Properties" button in
ServiceUI.printDialog is enabled in windows but clicking it
doesn't show any dialog.</p>
<p>According to <a
href="https://bugs.openjdk.java.net/browse/JDK-4673406"
title="RFE: Java Printing: Provide a way to display win32
printer driver's dialog" class="issue-link"
data-issue-key="JDK-4673406" moz-do-not-send="true"><strike>JDK-4673406</strike></a>,
the properties dialog isn't supported for direct uses with
javax.print.ServiceUI.printDialog, so it makes sense to disable
this properies button for this usecase.</p>
<p>This button is disabled in linux,mac already. This is because,
as per<br>
</p>
<p><a class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk/client/annotate/754ec520eb4a/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l964"
moz-do-not-send="true">http://hg.openjdk.java.net/jdk/client/annotate/754ec520eb4a/src/java.desktop/share/classes/sun/print/ServiceDialog.java#l964</a></p>
<p>the button is disabled if ServiceUIFactory is null and for
linux/mac, it is null</p>
<a class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk/client/file/754ec520eb4a/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1637"
moz-do-not-send="true">http://hg.openjdk.java.net/jdk/client/file/754ec520eb4a/src/java.desktop/unix/classes/sun/print/IPPPrintService.java#l1637</a><br>
<a class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk/client/file/754ec520eb4a/src/java.desktop/share/classes/sun/print/PSStreamPrintService.java#l490"
moz-do-not-send="true">http://hg.openjdk.java.net/jdk/client/file/754ec520eb4a/src/java.desktop/share/classes/sun/print/PSStreamPrintService.java#l490</a>
<p>but for windows, it created "Win32ServiceUIFactory" but it does
not handle the properties dialog if "role" requested to be
performed by ServiceUI is <= ServiceUIFactory.<span
style="color:#660e7a;font-weight:bold;font-style:italic;">MAIN_UIROLE</span></p>
<p><span style="color:#660e7a;font-weight:bold;font-style:italic;"></span>[<a
class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk/client/file/754ec520eb4a/src/java.desktop/windows/classes/sun/print/Win32PrintService.java#l1688"
moz-do-not-send="true">http://hg.openjdk.java.net/jdk/client/file/754ec520eb4a/src/java.desktop/windows/classes/sun/print/Win32PrintService.java#l1688</a>]<br>
</p>
<p>Proposed fix is to make sure this role is accounted for in the
buttonProperties enabling check.</p>
<p>Bug: <a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8246742"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8246742</a></p>
<p>webrev: <a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/~psadhukhan/8246742/webrev.0/"
moz-do-not-send="true">http://cr.openjdk.java.net/~psadhukhan/8246742/webrev.0/</a></p>
Regards<br>
Prasanta<br>
<span style="color: rgb(102, 14, 122);"></span> </blockquote>
</body>
</html>