Ground Rules

Edward Nevill edward.nevill at linaro.org
Tue Dec 15 15:50:16 UTC 2015


Hi folks,

I feel that now would be a good time to propose some ground rules for
this project.

Rule 0: Be Nice

Rule 1: See Rule 0

Rule 2: All patches should be reviewed on the aarch32 mailing list

Although there are no formal Reviewers it is expected that all
Contributions should be reviewed on this mailing list.

In the case of small contributions (a few 10s of lines at most) the
contributions may be included inline (please ensure you turn off all
formatting - format style: preformatted - to allow your patches to be
copied and pasted).

In the case of larger contibutions they should be uploaded to a web/ftp
server. Those of use with OpenJDK userid may use
http://cr.openjdk.java.net There is no requirement to use webrev
(http://openjdk.java.net/guide/webrevHelp.html) but this does make
patches easier to read.

Please allow sufficient time to allow others to review your patch.

I reserve the right to use the backout command:-)

Rule 3: Please enable jcheck

See: http://openjdk.java.net/projects/code-tools/jcheck/

I requested that jcheck should be partially enabled with
'comments=lax' (changeset comments aren't required to have a specific
format, but whitespace is checked). However jcheck seems to have been
fully enabled.

This means that a changeset comment is required which in turn means that
a JIRA issue is required for every patch (http://bugs.openjdk.java.net).

In practice this may not be a bad thing since having the JIRA issues
allows bugs/patches to be tracked much more easily, so I am inclined to
run with jcheck for the moment. If it becomes too painful I will ask Ops
to remove jcheck.

So the minimum hg comment required is

<bugid>: <what the problem is that you are trying to fix>
Reviewed-by: <reviewers OpenJDK id>

When submitting your patch you can use the anonymous name 'duke' for the
<reviewers OpenJDK id>.

Hack hacking!,
Ed.




More information about the aarch32-port-dev mailing list