bug fix: Floating point native code argument marshalling & debug build errors

Edward Nevill edward.nevill at gmail.com
Wed Dec 23 12:12:19 UTC 2015


Hi Joseph,

Changes look fine. With your build changes I am still unable to build a
fastdebug version due to other errors. Are you able to build a fastdebug
version?

Would you like to try committing these changes with your newly acquired
committer powers?

You will need to create a JIRA entry at bugs.openjdk.java.net, use
'aarch32' as the CPU type and include "aarch32:" at the start of the
title. You can use https://bugs.openjdk.java.net/browse/JDK-8139303 as a
template.

You will need jcheck enabled if you haven't done so already. See
http://openjdk.java.net/projects/code-tools/jcheck/

You must then commit the changes into your local repository (making sure
you have no other local committed or uncommitted changes) and enter the
mercurial log in the following format.

<bug id>: <description of problem>
Summary: <what you did to fix it>
Reviewed-by: enevill

Where <bug id> is the bug ID you got when you created the bug.

You may need to check out a fresh copy of the hotspot repo if you have
other committed changes locally (I generally keep two copies of the
repo, one for hacking and one clean one for changes I want to push).

You can commit both your changes under a single commit. IE. just include
the build fixes in commit for the floating point fix.

You can then do

hg outgoing

to check what changesets it would push and then if you are happy with
that do

hg push

Let me know if you run into any difficulties,

All the best,
Ed.

 
On Tue, 2015-12-22 at 21:48 +0000, Joseph Joyce wrote:
> Hi all,
> I've linked a webrev that contains fixes for:
> 
> Build errors when building a debug build due to incorrectly named
> variables used in assertions.
> 
> Floating point variables being placed only into even (double) floating
> point registers, this results in italic fonts in awt/swing
> applications.
> 
> http://cr.openjdk.java.net/~jjoyce/0/
> 
> Thanks
> Joseph




More information about the aarch32-port-dev mailing list