[aarch32 jdk9 patch] bug fix: rethrow NegativeArraySizeException

Edward Nevill edward.nevill at gmail.com
Tue Dec 29 18:40:58 UTC 2015


Hi Sergey, Triple Yang,

Thanks for fixing this. I have adopted Sergey's suggestion of using a BL.

All the best,
Ed.

On Tue, 2015-12-29 at 16:46 +0000, Sergey Nazarkin wrote:
> Hi Triple Yang,
> 
> since precise address is not required here I would  suggest to replace Branch call with “Branch with Link”.  This make code more compact by eliminating  " ldr(lr, Address(rfp, frame::return_addr_offset));” instruction.
> 
> ////////////////////  patch ////////////////////////
> diff -r f69a4ff3f0bb src/cpu/aarch32/vm/macroAssembler_aarch32.cpp
> --- a/src/cpu/aarch32/vm/macroAssembler_aarch32.cpp Wed Dec 23 12:21:32
> 2015 +0000
> +++ b/src/cpu/aarch32/vm/macroAssembler_aarch32.cpp Tue Dec 29 20:12:55
> 2015 +0800
> @@ -591,7 +591,7 @@
>     ldr(rscratch2, Address(java_thread,
> in_bytes(Thread::pending_exception_offset())));
>     Label ok;
>     cbz(rscratch2, ok);
> -    ldr(lr, Address(rfp, frame::return_addr_offset));
>   
> 
> 



More information about the aarch32-port-dev mailing list