[8] RFR: a little clean-up

[Fedor Burdun]

Hi all,

I would like to suggest to replace several __ call_Unimplemented() macros with asserts as in other ports. (x86, sparc,...)

<<<<<<<<<<<<<<>>>>>>>>>>>>>
diff --git a/src/cpu/aarch32/vm/macroAssembler_aarch32.hpp b/src/cpu/aarch32/vm/macroAssembler_aarch32.hpp
--- a/src/cpu/aarch32/vm/macroAssembler_aarch32.hpp
+++ b/src/cpu/aarch32/vm/macroAssembler_aarch32.hpp
@@ -456,7 +456,6 @@
   void load_heap_oop_not_null(Register dst, Address src);
   void store_heap_oop(Address dst, Register src);

-  // currently unimplemented
   // Used for storing NULL. All other oop constants should be
   // stored using routines that take a jobject.
   void store_heap_oop_null(Address dst);
diff --git a/src/cpu/aarch32/vm/templateTable_aarch32.cpp b/src/cpu/aarch32/vm/templateTable_aarch32.cpp
--- a/src/cpu/aarch32/vm/templateTable_aarch32.cpp
+++ b/src/cpu/aarch32/vm/templateTable_aarch32.cpp
@@ -3172,9 +3172,9 @@
 //-----------------------------------------------------------------------------
 // Calls

-void TemplateTable::count_calls(Register method, Register temp)
-{
-  __ call_Unimplemented();
+void TemplateTable::count_calls(Register method, Register temp) {
+  // implemented elsewhere
+  ShouldNotReachHere();
 }

 void TemplateTable::prepare_invoke(int byte_no,
@@ -3338,10 +3338,10 @@
   __ jump_from_interpreted(rmethod, r0);
 }

-void TemplateTable::fast_invokevfinal(int byte_no)
-{
-  __ call_Unimplemented();
-}
+void TemplateTable::fast_invokevfinal(int byte_no) {
+  transition(vtos, vtos);
+  assert(byte_no == f2_byte, "use this argument");
+  __ stop("fast_invokevfinal not used on aarch32");}

 void TemplateTable::invokeinterface(int byte_no) {
   transition(vtos, vtos);
<<<<<<<<<<<<<<>>>>>>>>>>>>>

The patch is in attachment too.


Thanks,
Fedor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cleanup-unimplemented.patch
Type: text/x-diff
Size: 1545 bytes
Desc: cleanup-unimplemented.patch
URL: <http://mail.openjdk.java.net/pipermail/aarch32-port-dev/attachments/20160415/c3886f85/cleanup-unimplemented-0001.patch>