RFR: small update of nativeInstruction

Edward Nevill edward.nevill at gmail.com
Mon Aug 15 13:58:23 UTC 2016


Hi Anton,

This looks fine,

Thanks,
Ed.

On Fri, 2016-08-12 at 09:51 +0000, Anton Kozlov wrote:
> Hi!
> 
> Could you please review small patch, that 
> 
> * fixes fatal message string; cleans comments because FIXMEs are bit
> irrelevant,
> there is no reason to not trust MacroAssembler's
> target_addr_for_insn, pd_patch_instruction
> 
> * removes movw/movt check for same target load register in
> NativeMovConstReg.
> Andrey Petushkov's ARMv6 patch will add mov+3orr variant for Move, so
> the check
> is starting to look very excessive. 
> 
> Thanks,
> Anton


More information about the aarch32-port-dev mailing list