[8u] RFR: enable -fPIC in hotspot

[Alex Kashchenko]

Hi Edward,

On 02/24/2016 10:31 AM, Edward Nevill wrote:
> Hi Alex,
>
>
> On Sat, 2016-02-20 at 22:13 +0000, Alex Kashchenko wrote:
>
>> Webrev:
>> http://cr.openjdk.java.net/~akasko/aarch32/jdk8u/hotspot_pic/webrev.00/
>>
>
> Thanks for this, I am going to suggest the following additional change
>
> diff -r b3e996878ddf make/linux/makefiles/rules.make
> --- a/make/linux/makefiles/rules.make	Tue Feb 23 11:15:22 2016 +0000
> +++ b/make/linux/makefiles/rules.make	Wed Feb 24 10:24:23 2016 +0000
> @@ -136,6 +136,10 @@
>   COMPILE_DONE    = && { echo Done with $<; }
>   endif
>
> +ifdef LP64
> +GENPIC = yes
> +endif
> +
>   ifeq ($(BUILDARCH), aarch32)
>   GENPIC = yes
>   endif
>
> That way, if anyone ever tries a 64 bit build (x86/aarch64) from the aarch32 tree it will still work, whereas the way you have patched it will break 64 bit builds. It may also make future merging easier, or at least more obvious.
>
>> I can create a JBS issue if it will be needed.
>>
>
> Yes, please, jcheck is enabled, so changes need a JBS. Please use port-stage-aarch32-8 in the Affects version field, set the cpu type to aarch32 and put aarch32: at the start of the title.
>
> If you are able to resubmit this as a changeset please do, otherwise a patch is fine.

Thanks for the review, I created an issue and updated the patch 
including your change:

  - issue: https://bugs.openjdk.java.net/browse/JDK-8150526
  - webrev with a changeset: 
http://cr.openjdk.java.net/~akasko/aarch32/jdk8u/hotspot_pic/webrev.02/

>
> Thanks,
> Ed.
>
>

-- 
-Alex