jdk8-aarch32: Crashing when running test case ParallelProbes.java

[Sergey Nazarkin]

Hi Chi Vo,

Could you provide stack trace of the crash? I see no reason for race condition here since the method doesn’t update any global variable. 


Sergey Nazarkin




> On 10 Nov 2016, at 12:49, Chi Vo <thegeek108 at gmail.com> wrote:
> 
> Hi All,
> 
> Hotspot crashing when I running test case
> */jdk/test/java/nio/file/Files/probeContentType/ParallelProbes.java*
> 
> As my analysis, the probeContentType is static method so It is class level.
> In this case, we allow many threads access it without synchronize. so It
> should be protected by synchronizing to avoid any inconsistent data or also
> corrupt data. I test this patch and it works fine.
> 
> diff -r dbe7e2abe8b2 -r c9e2721b4711
> 02.src/01.aarch32_jdk8u/jdk/src/share/classes/java/nio/file/Files.java
> --- a/02.src/01.aarch32_jdk8u/jdk/src/share/classes/java/nio/file/Files.java
> Fri
> Oct 07 15:23:45 2016 +0700
> +++ b/02.src/01.aarch32_jdk8u/jdk/src/share/classes/java/nio/file/Files.java
> Tue
> Oct 25 10:56:47 2016 +0700
> @@ -1610,7 +1610,7 @@
>      *          If a security manager is installed and it denies an
> unspecified
>      *          permission required by a file type detector implementation.
>      */
> -    public static String probeContentType(Path path)
> +    public synchronized static String probeContentType(Path path)
>         throws IOException
>     {
>         // try installed file type detectors
> 
> Please help take a look my patch.
> 
> Thanks you with best regards,
> Chi Vo