[11] RFR 8201604: Minimal Dynamic Constant support for ARM32 platform

[Bob Vandette]

The change looks good to me.

If you plan on pushing this to the mainline, you’ll need a “Reviewer”.

Bob.

> On Apr 20, 2018, at 11:03 AM, Boris Ulasevich <boris.ulasevich at bell-sw.com> wrote:
> 
> My bad. Correct link for updated webrev is:
> http://cr.openjdk.java.net/~dchuyko/boris.ulasevich/8201602/webrev.01/
> 
> Boris
> 
> On 20.04.2018 15:30, Boris Ulasevich wrote:
>> Thanks for the review!
>> > You declare rtmp to be R1_tmp but then use R1 directly.
>> You are right. I have clean it up.
>> > Do you not have to mask the flags with tos_state_mask?
>> Tos stays in top right bits, so we can skip the mask, but a good practice is to call verify_tos_state_shift() in this place. I have added it.
>> Updated webrev:
>> http://cr.openjdk.java.net/~dchuyko/boris.ulasevich/8201602/webrev.00/
>> Thank you,
>> Boris
>> On 19.04.2018 18:39, Bob Vandette wrote:
>>> In condy_helper …
>>> 
>>> Can you please use the Register declarations that you specify in this function.
>>> 
>>> You declare rtmp to be R1_tmp but then use R1 directly.
>>> 
>>> Is this section correct?
>>> 
>>> 632 const Address field(obj, off);
>>> 633
>>> 634 __ logical_shift_right(flags, flags, ConstantPoolCacheEntry::tos_state_shift);
>>> 635
>>> 
>>>   Do you not have to mask the flags with tos_state_mask?
>>> 
>>> Bob.
>>> 
>>> 
>>>> On Apr 17, 2018, at 11:44 AM, Boris Ulasevich <boris.ulasevich at bell-sw.com <mailto:boris.ulasevich at bell-sw.com>> wrote:
>>>> 
>>>> Hi all,
>>>> 
>>>> Please review a port of Minimal Constant Dynamic patch to ARM32 platform. The port is very similar to recent AARCH64 platform update (JDK-8190428). Tested on both ARM32/ARM64 builds by running jdk condy tests.
>>>> 
>>>> https://bugs.openjdk.java.net/browse/JDK-8201602
>>>> http://cr.openjdk.java.net/~dchuyko/boris.ulasevich/8201602/webrev.00/
>>>> 
>>>> Thank you,
>>>> Boris
>>>