From jcbeyler at google.com Tue Jan 2 17:19:42 2018 From: jcbeyler at google.com (JC Beyler) Date: Tue, 2 Jan 2018 09:19:42 -0800 Subject: RFR 8191985: Tlab refills for ARM In-Reply-To: <1514484882.2264.6.camel@gmail.com> References: <356550c0-adb7-bc91-c28f-e1943fad0f81@oracle.com> <1513776075.2757.7.camel@gmail.com> <8d5adc6a-86f0-7c18-5785-97d163159af2@oracle.com> <1514484882.2264.6.camel@gmail.com> Message-ID: Perfect, thanks Edward for testing :) Jc On Thu, Dec 28, 2017 at 10:14 AM, Edward Nevill wrote: > Hi, > > I have built and tested this on a Samsung Chromebook (armv7l). > > The tests I ran were jtreg hotspot tests patched vs original in three configurations, default gc (g1gc), parallelgc and serialgc. The results in all cases were identical before and after patching. > > Default gc (g1gc): passed: 1,435; failed: 9; error: 116 > ParallelGC: passed: 1,331; failed: 8; error: 112 > SerialGC: passed: 1,326; failed: 7; error: 112 > > Patch looks good to me. > > All the best, > Ed. > > On Wed, 2017-12-20 at 09:06 -0800, JC Beyler wrote: >> Hi all, >> >> Thanks for taking a look at the webrev! >> >> Here is the change relative to jdk/hs: >> http://cr.openjdk.java.net/~jcbeyler/8191985/webrev.02/ >> >> Let me know what you think, hopefully I didn't make a mistake when >> making the webrev :) >> Jc >> >> >> On Wed, Dec 20, 2017 at 5:50 AM, Daniel D. Daugherty >> wrote: >> > On 12/20/17 8:21 AM, Edward Nevill wrote: >> > > >> > > Hi Robin, >> > > >> > > I have eyeballed this, comparing it against the x86 version, and it looks >> > > good to me. >> > > >> > > I'll try to build and test this, but it will probably be sometime between >> > > Christmas and New Year. >> > > >> > > Just to confirm, the repo I should be patching and building is the >> > > following? >> > > >> > > > From edward.nevill at gmail.com Fri Jan 5 11:13:42 2018 From: edward.nevill at gmail.com (Edward Nevill) Date: Fri, 05 Jan 2018 11:13:42 +0000 Subject: RFR 8191985: Tlab refills for ARM In-Reply-To: References: <356550c0-adb7-bc91-c28f-e1943fad0f81@oracle.com> <1513776075.2757.7.camel@gmail.com> <8d5adc6a-86f0-7c18-5785-97d163159af2@oracle.com> <1514484882.2264.6.camel@gmail.com> Message-ID: <1515150822.4807.3.camel@gmail.com> Hi, Can this change be pushed to jdk/hs now? Have we got a formal Reviewer? I can push it if required. http://cr.openjdk.java.net/~jcbeyler/8191985/webrev.02/ https://bugs.openjdk.java.net/browse/JDK-8191985 All the best, Ed. On Tue, 2018-01-02 at 09:19 -0800, JC Beyler wrote: > Perfect, thanks Edward for testing :) > Jc > > > On Thu, Dec 28, 2017 at 10:14 AM, Edward Nevill com> wrote: > > Hi, > > > > I have built and tested this on a Samsung Chromebook (armv7l). > > > > The tests I ran were jtreg hotspot tests patched vs original in > > three configurations, default gc (g1gc), parallelgc and serialgc. > > The results in all cases were identical before and after patching. > > > > Default gc (g1gc): passed: 1,435; failed: 9; error: 116 > > ParallelGC: passed: 1,331; failed: 8; error: 112 > > SerialGC: passed: 1,326; failed: 7; error: 112 > > > > Patch looks good to me. > > > > All the best, > > Ed. > > > > On Wed, 2017-12-20 at 09:06 -0800, JC Beyler wrote: > > > Hi all, > > > > > > Thanks for taking a look at the webrev! > > > > > > Here is the change relative to jdk/hs: > > > http://cr.openjdk.java.net/~jcbeyler/8191985/webrev.02/ > > > > > > Let me know what you think, hopefully I didn't make a mistake > > > when > > > making the webrev :) > > > Jc > > > > > > From aph at redhat.com Fri Jan 5 17:15:40 2018 From: aph at redhat.com (Andrew Haley) Date: Fri, 5 Jan 2018 17:15:40 +0000 Subject: RFR 8191985: Tlab refills for ARM In-Reply-To: <1515150822.4807.3.camel@gmail.com> References: <356550c0-adb7-bc91-c28f-e1943fad0f81@oracle.com> <1513776075.2757.7.camel@gmail.com> <8d5adc6a-86f0-7c18-5785-97d163159af2@oracle.com> <1514484882.2264.6.camel@gmail.com> <1515150822.4807.3.camel@gmail.com> Message-ID: On 05/01/18 11:13, Edward Nevill wrote: > Can this change be pushed to jdk/hs now? Have we got a formal Reviewer? > I can push it if required. > > http://cr.openjdk.java.net/~jcbeyler/8191985/webrev.02/ > > https://bugs.openjdk.java.net/browse/JDK-8191985 OK. -- Andrew Haley Java Platform Lead Engineer Red Hat UK Ltd. EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From jcbeyler at google.com Fri Jan 5 19:41:24 2018 From: jcbeyler at google.com (JC Beyler) Date: Fri, 5 Jan 2018 11:41:24 -0800 Subject: RFR 8191985: Tlab refills for ARM In-Reply-To: References: <356550c0-adb7-bc91-c28f-e1943fad0f81@oracle.com> <1513776075.2757.7.camel@gmail.com> <8d5adc6a-86f0-7c18-5785-97d163159af2@oracle.com> <1514484882.2264.6.camel@gmail.com> <1515150822.4807.3.camel@gmail.com> Message-ID: Thanks both, Anything I need to do on my side? Jc On Fri, Jan 5, 2018 at 9:15 AM, Andrew Haley wrote: > On 05/01/18 11:13, Edward Nevill wrote: >> Can this change be pushed to jdk/hs now? Have we got a formal Reviewer? >> I can push it if required. >> >> http://cr.openjdk.java.net/~jcbeyler/8191985/webrev.02/ >> >> https://bugs.openjdk.java.net/browse/JDK-8191985 > > OK. > > -- > Andrew Haley > Java Platform Lead Engineer > Red Hat UK Ltd. > EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From dmitry.samersoff at bell-sw.com Tue Jan 9 10:52:29 2018 From: dmitry.samersoff at bell-sw.com (Dmitry Samersov) Date: Tue, 9 Jan 2018 13:52:29 +0300 Subject: RFR 8191985: Tlab refills for ARM In-Reply-To: <1515150822.4807.3.camel@gmail.com> References: <356550c0-adb7-bc91-c28f-e1943fad0f81@oracle.com> <1513776075.2757.7.camel@gmail.com> <8d5adc6a-86f0-7c18-5785-97d163159af2@oracle.com> <1514484882.2264.6.camel@gmail.com> <1515150822.4807.3.camel@gmail.com> Message-ID: <62804c78-5243-2462-9204-ec59cb67d63d@bell-sw.com> Edward, On 05.01.2018 14:13, Edward Nevill wrote: > Hi, > > Can this change be pushed to jdk/hs now? > Have we got a formal Reviewer? The fix looks good to me. > I can push it if required. Let me know if you need a help to push the fix. -Dmitry > > http://cr.openjdk.java.net/~jcbeyler/8191985/webrev.02/ > > https://bugs.openjdk.java.net/browse/JDK-8191985 > > All the best, > Ed. > > On Tue, 2018-01-02 at 09:19 -0800, JC Beyler wrote: >> Perfect, thanks Edward for testing :) >> Jc >> >> >> On Thu, Dec 28, 2017 at 10:14 AM, Edward Nevill > com> wrote: >>> Hi, >>> >>> I have built and tested this on a Samsung Chromebook (armv7l). >>> >>> The tests I ran were jtreg hotspot tests patched vs original in >>> three configurations, default gc (g1gc), parallelgc and serialgc. >>> The results in all cases were identical before and after patching. >>> >>> Default gc (g1gc): passed: 1,435; failed: 9; error: 116 >>> ParallelGC: passed: 1,331; failed: 8; error: 112 >>> SerialGC: passed: 1,326; failed: 7; error: 112 >>> >>> Patch looks good to me. >>> >>> All the best, >>> Ed. >>> >>> On Wed, 2017-12-20 at 09:06 -0800, JC Beyler wrote: >>>> Hi all, >>>> >>>> Thanks for taking a look at the webrev! >>>> >>>> Here is the change relative to jdk/hs: >>>> http://cr.openjdk.java.net/~jcbeyler/8191985/webrev.02/ >>>> >>>> Let me know what you think, hopefully I didn't make a mistake >>>> when >>>> making the webrev :) >>>> Jc >>>> >>>>