[RFR] jdk9.0.4+12 + functionality
Edward Nevill
edward.nevill at gmail.com
Sun Jun 10 20:48:19 UTC 2018
Hi Andrey,
Thanks for that. Sorry for the delay.
I have build aarch32 versions of server, client and core and arm versions of server and client.
I had to make a minor change to Copy-java.base.gmk in order to get the 'core' build working again (patch below)
I also did some sanity checks with jtreg/hotspot and jcstress - m quick
hotspot (aarch32 client)
Test results: passed: 1,224; failed: 34; error: 53
hotspot (aarch32 server)
Test results: passed: 1,259; failed: 37; error: 43
jcstress (aarch32 server)
(ETA: 00:00:18) (Rate: 2.66E+06 samples/sec) (Tests: 11560 of 11560) (Forks: 69360 of 69360) (Iterations: 416000 of 416160; 414573 passed, 1427 failed, 0 soft errs, 0 hard errs)
The large number of failure on jcstress is a bit disconcerting.
Nonetheless, I propose pushing this within the next few days. The issues above can be addressed later and there is no point holding off pushing until all issues are addressed.
Can you give me a list of people (names and email addresses) of people who contributed to this for inclusion in the commit.
Many thanks,
Ed.
Patch to enable 'core' build again.
--- CUT HERE ---
diff -r d54486c189e5 make/copy/Copy-java.base.gmk
--- a/make/copy/Copy-java.base.gmk Wed Feb 14 07:32:50 2018 -0800
+++ b/make/copy/Copy-java.base.gmk Sun Jun 10 21:47:02 2018 +0100
@@ -152,6 +152,11 @@
$(PRINTF) "-minimal KNOWN\n">>$(@)
$(PRINTF) "-server ALIASED_TO -minimal\n">>$(@)
$(PRINTF) "-client ALIASED_TO -minimal\n">>$(@)
+ else
+ ifeq ($(call check-jvm-variant, core), true)
+ $(PRINTF) "-server KNOWN\n">>$(@)
+ $(PRINTF) "-client ALIASED_TO -server\n">>$(@)
+ endif
endif
endif
endif
--- CUT HERE ---
On Thu, 2018-05-31 at 14:23 +0300, Andrey Petushkov wrote:
> Oops, glitch on my side. Sorry. Fixed, webrev updated
>
> Thanks,
> Andrey
>
> > On 30 May 2018, at 21:32, Andrey Petushkov <andrey.petushkov at gmail.com> wrote:
> >
> > Hmm, I've really removed this file since the functionality is not relevant for aarch32, and that did not cause any problems on my side.. Please let me doublecheck
> >
> > Thank you,
> > Andrey
> >
> > On Wed, May 30, 2018 at 7:41 PM Edward Nevill <edward.nevill at gmail.com> wrote:
> > > OK. So I applied both sets of patches and I get
> > >
> > > /work/ed/openjdk/jdk9u-aarch32/hotspot/src/share/vm/c1/c1_FpuStackSim.hpp:36:36: fatal error: c1_FpuStackSim_aarch32.hpp: No such file or directory
> > > #include CPU_HEADER(c1_FpuStackSim)
> > >
> > > My build command is
> > >
> > > bash ./configure --with-jobs=2 --disable-warnings-as-errors --with-boot-jdk=/work/ed/images/jdk9u --with-jvm-variants=server
> > > make images
> > >
> > > All the best,
> > > Ed.
> > >
> > >
> > > On Wed, 2018-05-30 at 16:52 +0300, Andrey Petushkov wrote:
> > > > Would it be ok if you just check the final state?
> > > >
> > > > Andrey
> > > >
>
>
More information about the aarch32-port-dev
mailing list