RFR 8201786: Modularize interpreter GC barriers: leftovers for ARM32

Aleksey Shipilev shade at redhat.com
Wed May 2 13:51:00 UTC 2018


On 05/02/2018 01:14 PM, Erik Österlund wrote:
> I spoke too soon. I realize now that in do_oop_store/load, you have a decorator argument, but you
> never pass it along to load/store_heap_oop. That seems wrong. Now it seems like it works because you
> never pass in any decorators to do_oop_store/load. For example the array accesses have
> IN_HEAP_ARRAY, which causes card marking barriers to use precise marking instead. But it looks like
> they will never learn that this was indeed an array as the decorators are not passed along.

Argh. It is worse than that: there seems to be the implicit conversion of "bool is_null" to
"DecoratorSet set", which is wildly wrong. Fixed like this:
  http://cr.openjdk.java.net/~shade/8201786/webrev.04.diff

Full webrev:
  http://cr.openjdk.java.net/~shade/8201786/webrev.04/

arm32-hflt seems to still build/work :)

Thanks,
-Aleksey



More information about the aarch32-port-dev mailing list