RFR: u212

[snazarkin at azul.com]

Pushed and tagged  jdk8u212-b04-aarch32-190430


-----Original Message-----
From: Andrew John Hughes <gnu.andrew at redhat.com> 
Sent: Tuesday, April 30, 2019 6:20 PM
To: Sergey Nazarkin <snazarkin at azul.com>
Cc: aarch32-port-dev at openjdk.java.net
Subject: Re: RFR: u212



On 30/04/2019 15:11, Sergey Nazarkin wrote:
> I’ve prepared u212 for aarch32 by merging jdk8u212-b04. 
> 
> My  fix for " 8214189: [AArch32] …” is
> 
> diff -r 1ea01fa4d62d src/cpu/aarch32/vm/assembler_aarch32.hpp
> --- a/src/cpu/aarch32/vm/assembler_aarch32.hpp  Tue Apr 30 16:40:22 
> 2019 +0300
> +++ b/src/cpu/aarch32/vm/assembler_aarch32.hpp  Tue Apr 30 17:11:13 
> +++ 2019 +0300
> @@ -264,6 +264,8 @@
> 
>  #define starti Instruction_aarch32 do_not_use(this); 
> set_current(&do_not_use)
> 
> +static inline unsigned long uabs(long n) { return uabs((jlong)n); }
> +
>  #define S_DFLT ::lsl()
>  #define C_DFLT AL
> 
> If there is no objection I’ll push
> 
> 
> Sergey Nazarkin
> 
> 

That's simpler than what I had as well :-)

I did consider that, but wasn't sure if it would conflict with the other uabs. I guess if it's only in the AArch32 part of the tree, it's ok.

Thanks for the quick response. Once you push, I'll update to your version.

Thanks,
--
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222 https://keybase.io/gnu_andrew