RFR: 8285760: Update .jcheck/conf for aarch32-port move to git
Sergey Nazarkin
snazarkin at azul.com
Fri Apr 29 11:29:41 UTC 2022
Hmm, it seems jcheck works only with committed config. I get several errors when reverified repo before push:
[tags] error: illegal tag name: jdk8u-core-final
….
[tags] error: illegal tag name: jdk8u76-b00-aarch32-160415
[tags] error: illegal tag name: jdk8u91-b14-aarch32-160510
[committer] error: f12e9449: Sergey Nazarkin is not committer in project jdk8u
[reviewers] error: f12e9449: 1 reviewer required, found 0
Looks like, we need switch project to "aarch32-port” and update tag regex.
Regex difference with jdk8u
-tags=(?:jdk-(?:[1-9]([0-9]*)(?:\.(?:0|[1-9][0-9]*)){0,4})(?:\+(?:(?:[0-9]+))|(?:-ga)))|(?:jdk[4-9](?:u\d{1,3})?-(?:(?:b\d{2,3})|(?:ga)))|(?:hs\d\d(?:\.\d{1,2})?-b\d\d)
+tags=(?:jdk-(?:[1-9]([0-9]*)(?:\.(?:0|[1-9][0-9]*)){0,4})(?:\+(?:(?:[0-9]+))|(?:-ga)))|(?:jdk[4-9](?:u\d{1,3})?-(?:(?:b\d{1,3})|(?:ga))(?:-a?arch32-[0-9]+)?)|(?:hs\d\d(?:\.\d{1,2})?-b\d\d)|(?:jdk8u-core-final)
Finally this conf left only single error about reviewer required, that can be skipped.
diff --git a/.jcheck/conf b/.jcheck/conf
index 25f035878d..1f5d370f43 100644
--- a/.jcheck/conf
+++ b/.jcheck/conf
@@ -1,4 +1,31 @@
-project=jdk8
-bugids=dup
-comments=lax
-tags=lax
+[general]
+project=aarch32-port
+jbs=JDK
+version=openjdk8u342
+
+[checks]
+error=author,committer,reviewers,merge,issues,executable,symlink,message,hg-tag,whitespace
+
+[repository]
+tags=(?:jdk-(?:[1-9]([0-9]*)(?:\.(?:0|[1-9][0-9]*)){0,4})(?:\+(?:(?:[0-9]+))|(?:-ga)))|(?:jdk[4-9](?:u\d{1,3})?-(?:(?:b\d{1,3})|(?:ga))(?:-a?arch32-[0-9]+)?)|(?:hs\d\d(?:\.\d{1,2})?-b\d\d)|(?:jdk8u-core-final)
+branches=
+
+[census]
+version=0
+domain=openjdk.org
+
+[checks "whitespace"]
+files=.*\.cpp|.*\.hpp|.*\.c|.*\.h|.*\.java
+
+[checks "merge"]
+message=Merge
+
+[checks "reviewers"]
+committers=1
+ignore=duke
+
+[checks "committer"]
+role=committer
+
+[checks "issues"]
+pattern=^([124-8][0-9]{6}): (\S.*)$
> On 29 Apr 2022, at 09:55, Anton Kozlov <akozlov at azul.com> wrote:
>
>
>
> On 4/28/22 19:04, Sergey Nazarkin wrote:
>> Nice catch! The idea was to prevent SKARA to poison JBS with references to this port, if bug auto resolve would be occasionally enabled.
>
> Since this is not enabled for now, looks fine.
>
>> So let’s keep original file with committers right to review.
>
> LGTM!
>
> Thanks,
> Anton
More information about the aarch32-port-dev
mailing list