[aarch64-port-dev ] Delete KILL of rFlagsReg from boolean ops

[Andrew Dinn]

On 10/12/13 16:40, Andrew Haley wrote:
> We're using the flag-setting form of some boolean ops; fixed thusly.

Should this fix not also have removed the rFlagsReg cr argument from the
instruction signatures? e.g.

> # HG changeset patch
> # User aph
> # Date 1386685708 0
> # Node ID 93b2e2d86bbd1e550697dfb099cd2eb38ca69b19
> # Parent  f8503cf6d8a891cd780fad9d4c8c276dd5b717a5
> Delete KILL of rFlagsReg from boolean ops
> 
> diff -r f8503cf6d8a8 -r 93b2e2d86bbd src/cpu/aarch64/vm/aarch64.ad
> --- a/src/cpu/aarch64/vm/aarch64.ad	Tue Dec 10 13:52:33 2013 +0000
> +++ b/src/cpu/aarch64/vm/aarch64.ad	Tue Dec 10 14:28:28 2013 +0000
> @@ -7106,10 +7106,8 @@
>  instruct negI_reg(iRegINoSp dst, iRegIorL2I src, immI0 zero, rFlagsReg cr) %{
>    match(Set dst (SubI zero src));


should this not be

  instruct negI_reg(iRegINoSp dst, iRegIorL2I src, immI0 zero)

regards,


Andrew Dinn
-----------