[aarch64-port-dev ] RFR: remove -DAMD64 from sysdefs

[Andrew Haley]

On 07/18/2013 11:14 AM, Edward Nevill wrote:
> Hi folks,
> 
> sysdefs in platform_aarch64 currently says
> 
> -DAARCH64 -DAMD64
> 
> This is broken logic. It should define only one architecture. The 
> -DAMD64 is there so that the BUILTIN_SIM build the necessary bits for 
> X86 or AMD64.
> 
> However there are many cases where this X86 code is not desirable or 
> correct.
> 
> In these cases the code has been conditionalised with
> 
> #ifdef X86
> #ifndef TARGET_ARCH_aarch64
> ..
> 
> I have changed the logic so that we positively identify the pieces of 
> code we actually want IE.
> 
> #if defined(X86) || defined(AARCH64)
> 
> if the code is required for both HW/Model and BUILTIN_SIM or
> 
> #if defined(x86) || defined(BUILTIN_SIM)
> 
> if the code is required only for the BUILTIN_SIM.
> 
> Note, there is an implicit assumption that BUILTIN_SIM is 64 bit X86 
> only, but that assumption was always there in any case.
> 
> I have tested release and slowdebug versions of the build on both the 
> model and the BUILTIN_SIM and as far as I can tell the behaviour is the 
> same as before.
> 
> Andrew Dinn: There is one section of code in c1_LIRAssembler.cpp which 
> is C2 only, which I am not sure about.
> 
> -#if defined(X86) && defined(TIERED)
> +#if (defined(X86) || defined(AARCH64)) && defined(TIERED)
>    // C2 leave fpu stack dirty clean it
> 
> I have defaulted to leave this section of code as that is what happened 
> by default before but if you could review it to see if it is actually 
> necessary.
> 
> Ta very much,

This is OK.

Please fix your mailer.

Andrew.