[aarch64-port-dev ] RFR: Fixes for native builds

[Andrew Dinn]

Hi Ed,

On 25/07/13 11:41, ed at camswl.com wrote:
> The following 2 changesets (1 for jdk8, 1 for jdk) make it build natively.
> 
> Ok to push?

I'm not sure . . . perhaps you can explain what the patches do?

> diff -r 3a46878d2ffb -r 03e94d825937 common/autoconf/platform.m4
> --- a/common/autoconf/platform.m4	Mon Jul 15 15:02:39 2013 +0100
> +++ b/common/autoconf/platform.m4	Thu Jul 25 11:30:35 2013 +0100
> @@ -345,6 +345,9 @@
>        s390)
>          ZERO_ARCHFLAG="-m31"
>          ;;
> +      arm*)
> +        ZERO_ARCHFLAG=""
> +        ;;
>        aarch64)
>          ZERO_ARCHFLAG=""
>          ;;


Why is it necessary to add a case for arm* -- what has this to do with
how aarch64 works?

> --- CUT HERE ---

> diff -r b28c6241e16e -r 3c777c472368 makefiles/GensrcX11Wrappers.gmk
> --- a/makefiles/GensrcX11Wrappers.gmk	Tue Jul 09 16:04:18 2013 +0100
> +++ b/makefiles/GensrcX11Wrappers.gmk	Thu Jul 25 11:32:02 2013 +0100
> @@ -89,7 +89,7 @@
>      # Compile the C code into an executable.
>      $(GENSRC_X11WRAPPERS_TMP)/sizer.%.exe : $(GENSRC_X11WRAPPERS_TMP)/sizer.%.c
>  	$(MKDIR) -p $(@D)
> -	(cd $(@D) && $(CC) -m$* -o $@ $< \
> +	(cd $(@D) && $(CC) -o $@ $< \
>                $(X_CFLAGS) \
>                $(X_LIBS) \
>                -I$(JDK_OUTPUTDIR)/include \


Why is there a need to remove the -m option? (what was the point of
having it in the first place? :-)

regards,


Andrew Dinn
-----------
Principal Software Engineer
Red Hat UK Ltd
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Mark Hegarty (Ireland), Matt Parson
(USA), Charlie Peters (USA)