[aarch64-port-dev ] Use an explicit set of registers rather than a bitmap for psh and pop operations.
Edward Nevill
edward.nevill at linaro.org
Wed Apr 23 08:34:07 UTC 2014
Hi Andrew,
It looks fine to me. A couple of small points
> Use an explicit set of registers rather than a bitmap for psh and pop operations.
'push' rather than 'psh' in the commit comment
(if this is a pain to fix don't bother)
In class RegSet for consistency I would provide
RegSet operator-(Register r1)
You have RegSet + Register and RegSet - RegSet. I would be surprised if RegSet - Register did not work for me.
Regards,
Ed.
On Tue, 2014-04-22 at 19:10 +0100, Andrew Haley wrote:
> The code using push() and pop() was getting to be very hard to understand.
More information about the aarch64-port-dev
mailing list