[aarch64-port-dev ] RFR: Large code cache

Andrew Haley aph at redhat.com
Fri Dec 12 11:34:40 UTC 2014


On 12/12/2014 10:39 AM, Edward Nevill wrote:
> On Thu, 2014-12-11 at 15:28 +0000, Andrew Haley wrote:
>> On 12/11/2014 03:15 PM, Edward Nevill wrote:
>>> On Tue, 2014-12-09 at 19:03 +0000, Andrew Haley wrote:
>> (mine, probably).  The comment above
>> Runtime1::generate_exception_throw says that its argument is passed on
>> the stack because registers must be preserved, but clearly they
>> aren't.  Maybe its argument should be passed on the stack?  But I'm OK
>> with using rscratch2 for the far_call if you like.  Please remove (or
>> correct) the comment here:
>>
>> // target: the entry point of the method that creates and posts the exception oop
>> // has_argument: true if the exception needs an argument (passed on stack because registers must be preserved)
>>
>> OopMapSet* Runtime1::generate_exception_throw(StubAssembler* sasm, address target, bool has_argument) {
> 
> Wilco. Would you like to push your Large code cache patch? Then I can push this with corrections to the above comment.

Done.

Andrew.




More information about the aarch64-port-dev mailing list