[aarch64-port-dev ] RFR: Remove mistaken shift in form_address
Andrew Haley
aph at redhat.com
Wed Mar 19 17:30:48 UTC 2014
On 03/19/2014 04:23 PM, Edward Nevill wrote:
> I believe the shift removed by the patch below is mistaken. 'byte_offset' is already the offset in bytes so shifting it by scale of the data being loaded is wrong.
Absolutely right. It would be much less confusing if the argument passed
were a size rather than a shift, and form_address used exact_log2 to get
the shift. But your patch is OK.
Andrew.
More information about the aarch64-port-dev
mailing list