[aarch64-port-dev ] RFR: JDK8: Add support for CRC32 intrinsic

Andrew Haley aph at redhat.com
Tue May 27 09:04:51 UTC 2014


On 05/24/2014 11:39 AM, Andrew Haley wrote:
> +    // _areturn
>> +    // __ mov(sp, r13);           // set sp to sender sp
>> +    __ ret(rscratch1);
>> +

Also, I think we should restore the sender's SP.  It is the contract of
an entry point that at return it restore the sender's SP from R13,
but unfortunately we are not consistent about this.

The problem is that if your interpreter version of CRC32.update is ever
called from a C2I adapter it will fail to restore the caller's SP and
the caller will crash when you return to it.  This can't happen at the
moment because there is a compiler version of CRC32.update, but I think
we should at least try to be consistent.

I think it just needs at the end

  __ andr(sp, r13, -16);

Andrew.



More information about the aarch64-port-dev mailing list