[aarch64-port-dev ] AARCH64: Changes to HotSpot shared code

[Andrew Haley]

Hi,

On 12/11/14 08:32, Lindenmaier, Goetz wrote:

> the change does not build as the file 
>    sun.jvm.hotspot.debugger.MachineDescriptionAArch64.java
> is missing.

Sorry, I will fix that in a new webrev.

> If I add that file, I get                                                                                                   
>    cc1plus: error: unrecognized command line option "-Wno-error=cpp"
> We are using g++ 4.1.2.

This is very awkward.  Without this command it does not build on a
recent GCC.  I want to avoid yet more configury if I can, so I'll
have a think.

> Then I get 
>   os_linux.cpp:1927: error: EM_AARCH64 was not declared in this scope
> A few lines above it's dealt with a missing EM_486 definition.
> I guess this should be fixed similarly.

Okay, I will try to see why this does not work for you.

> After these fixes the change builds and runs on PPC nicely.
> 
> Considering the change in metaspace: I just proposed a similar change
> for the java heap, see 
> http://cr.openjdk.java.net/~goetz/webrevs/8064457-disjoint/webrev.00/
> 
> Don't you want to use 4*G << narrow_klass_shift() for alignment and
> the test for zerobased compressed klasses?  That's what we enforce for
> the heap. I think the shift is superior to movk, as it preserves 0
> (which is rare for klass pointers, I admit).

I don't understand what you are saying.  We have a solution that
can compress a klass in one instruction.  What would we want that
is different?

> And, could you add #if !defined(AARCH64) && !defined(PPC64) at this place?  We'll 
> implement the optimized klass compression, too. ;)

Okay, if it makes sense to do so.

> In ci_LIR.hpp|cpp please use AARCH64 in #ifs.  
> 
> I would propose to add aarch stuff in alphabetical order
> (or maybe establish alphabetical order where absent) whenever all cpus are 
> listed (makefiles, os_linux, vm_version, ...)
> 
> Also, should we sort the cpu includes alphabetically at some point?

I'm trying to make the minimum changes, but I will do whatever people
want.

Andrew.