[aarch64-port-dev ] AArch64 staging forests

Vladimir Kozlov vladimir.kozlov at oracle.com
Fri Oct 10 22:49:45 UTC 2014


Thank you, Iris

Andrew,

To avoid problems in a future  (which would require rollback changes, 
for example) I want all us to follow rules we use in Hotspot/JDK 
development.

All changes have to be reviewed by jdk9 official Reviewers before push. 
2 official reviews are required by rules. Me and Roland are Reviewers. 
Other people may review changes too.
Very small changes need only one official review.

Requests for review should be sent to hotspot-dev at openjdk.java.net for 
Hotspot changes and jdk9-dev at openjdk.java.net for jdk changes. You can 
also CC them to aarch64-port-dev at openjdk.java.net for records.

All changes which create new directories, add or modify shared files 
should pass our testing system: JPRT. Roland will help with that.
When we get aarch64 committer status we will help to push changes using 
JPRT.

Later on when you need to do changes only in aarch64 specific files, 
they could be pushed after reviews without testing in JPRT.

For each change a separate JBS report should be filed. Please, add 
prefix AARCH64 to report's synopsis.

Please, make sure Changeset Comments follow official format:

     <bugid>: <synopsis-of-bug>
     Summary: <summary-of-code-change>
     Reviewed-by: <reviewer1>, <reviewer2>
     Contributed-by: <contributor-email>

http://openjdk.java.net/guide/producingChangeset.html

Make sure your ~/.hgrc has following information:

[ui]
username=aph
[extensions]
jcheck = $DIR/jcheck.py
[hooks]
pretxnchangegroup=python:jcheck.hook
pretxncommit=python:jcheck.hook

http://openjdk.java.net/projects/code-tools/jcheck/

Thanks,
Vladimir

On 10/10/14 3:08 PM, Iris Clark wrote:
> Hi, Andrew.
>
> I've created your forest:
>
> http://hg.openjdk.java.net/aarch64-port/stage/
>
> It's a clone of the JDK 9 master forest, jdk9/jdk9 with tag jdk9-b34.  jcheck is fully enabled as it would be for a JDK 9 forest.  Notifications go to aarch64-port-dev at ojn.  At the moment,  you are the only one who can push to it.  Hgupdater is not on as we haven't heard from Joe regarding the new JIRA Version.
>
> I recommend that you sync the new forest with either jdk9/jdk9 (after the next promotion) or jdk9/dev as a test that everything is configured correctly.
>
> Thanks,
> iris
>
> -----Original Message-----
> From: Iris Clark
> Sent: Friday, October 10, 2014 9:55 AM
> To: Andrew Haley; Vladimir Kozlov
> Cc: Iris Clark
> Subject: RE: AArch64 staging forests
>
> Hi, Andrew.
>
>> I will be able to add authors once they are JDK9 authors, right?  I'm rather hazy.
>
> Pushers to the aarch64-port/stage repo need to be at least Committers in both AArch64 and JDK 9.  Similarly, changeset authors will need to be at least Authors in both Projects.
>
> You are at least a Committer in both Projects so you're set.
>
> AndrewD needs to be a JDK 9 Author to be listed as a changeset author.  Until that time, his contributions should be acknowledged in the "Contributed-by" line.
>
> Vladimir (and possibly Roland and Dean) need to become AArch64 Committers if you want to allow them to push into aarch64-port/stage.
>
> For the aarch64-port/stage forest, I will configure it so that you are the only pusher.  I will assume that I should add Vladimir, Roland, and Dean once I see the Registrar process their CFVs.  If you want to add anybody else in the future, just send mail to ops at ojn and somebody (probably me) will take care of updating the server configuration.  AndrewD (and any additional changeset authors) will be automatically allowed once the Registrar adds them to the JDK 9 census entry.
>
> If you're still hazy about a few things, I'd be happy to chat on the phone to answer your questions.
>
> Thanks,
> iris
>
> -----Original Message-----
> From: Andrew Haley [mailto:aph at redhat.com]
> Sent: Friday, October 10, 2014 8:38 AM
> To: Iris Clark; Vladimir Kozlov
> Subject: Re: AArch64 staging forests
>
> On 10/10/2014 04:21 PM, Iris Clark wrote:
>> Hi, Andrew.
>>
>> Do you agree with Vladimir's request?
>
> Yes.
>
>>>> Hmmm.  I can configure jcheck in aarch64-port/stage to allow
>>>> duplicate bugIDs, but then you won't be able to directly push those
>>>> changesets into a jdk9/* forest since that forest's configuration
>>>> doesn't allow it.
>>
>>> Please, don't do that - don't relax jcheck. Configure jcheck as we
>>> did for PPC/AIX.
>>
>> I think that the jcheck settings and the JIRA version are the only
>> things that still need to be settled.  I'll set up the forest today,
>> assuming default jcheck (we can always relax if you don't agree with
>> Vladimir).  You didn't want automatic bug updates (hg updates) so the
>> lack of a JIRA version in the system shouldn't be a problem.
>> You'll have the option to enable it once the version appears in JIRA
>
> OK, thanks.
>
> I will be able to add authors once they are JDK9 authors, right?  I'm rather hazy.
>
> Andrew.
>


More information about the aarch64-port-dev mailing list