[aarch64-port-dev ] RFR: 8075930: AARCH64: Use FP Register in C2
Edward Nevill
edward.nevill at linaro.org
Fri Apr 10 08:54:59 UTC 2015
Hi Vladimir,
On Thu, 2015-04-09 at 10:32 -0700, Vladimir Kozlov wrote:
> Hi Edward,
>
> In frame() I think check !defined(COMPILER2) is useless because COMPILER2 is always defined in 64-bit Server Hotspot VM.
> Unless you have configuration without C2. I think it should be dynamic check after you find who generated this _cb.
> Can you explain what this code does (there is not comment):
We do build without C2 as part of our testing. However, as Andrew Haley said, this is old debug code, so I propose simply removing it. Its usefulness is rather limited once fp can be allocated as a general purpose register.
>
> 80 #ifndef PRODUCT
> 81 if (fp)
> 82 if (sp > fp || (fp - sp > 0x100000))
> 83 for(;;)
> 84 asm("nop");
> 85 #endif
New webrev removing this code @
http://cr.openjdk.java.net/~enevill/8075930/webrev.03/
All the best,
Ed.
More information about the aarch64-port-dev
mailing list