[aarch64-port-dev ] RFR: 8076488: AARCH64: jdk9 fails to build from source

Andrew Haley aph at redhat.com
Fri Apr 17 09:43:03 UTC 2015


On 04/17/2015 10:40 AM, Andrew Haley wrote:
> On 04/17/2015 10:39 AM, Roland Westrelin wrote:
>>>> Looks good to me.
>>>
>>> As a 2nd review***, yes this patch is good. Is that enough for it to be
>>> pushed to jdk9?
>>>
>>> ***n.b. I am not a JDK9 committer or reviewer but this is AArch64 only
>>> and I /am/ an aarch64-port committer/reviewer.
>>
>> In case another review helps: that looks good to me. 
> 
> OK, I'll push it.

Ah, no I won't.  My patch already fixed this, and (IMO) in a much better
way.  This patch is already in jprt, and will emerge soon, I hope.

diff -r 9c916db4bf3b -r 6463e57d9761 src/cpu/aarch64/vm/interp_masm_aarch64.hpp
--- a/src/cpu/aarch64/vm/interp_masm_aarch64.hpp        Thu Apr 09 17:38:28 2015 -0700
+++ b/src/cpu/aarch64/vm/interp_masm_aarch64.hpp        Tue Apr 14 11:43:18 2015 +0100
@@ -1,6 +1,6 @@
 /*
  * Copyright (c) 2003, 2011, Oracle and/or its affiliates. All rights reserved.
- * Copyright (c) 2014, Red Hat Inc. All rights reserved.
+ * Copyright (c) 2014, 2015, Red Hat Inc. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -40,6 +40,8 @@

  protected:
   // Interpreter specific version of call_VM_base
+  using MacroAssembler::call_VM_leaf_base;
+
   virtual void call_VM_leaf_base(address entry_point,
                                  int number_of_arguments);

Andrew.




More information about the aarch64-port-dev mailing list