[aarch64-port-dev ] 8078263: AARCH64: Volatile fields should be accessed with ldar and stlr

[Andrew Haley]

On 04/21/2015 02:43 PM, Andrew Dinn wrote:
> On 21/04/15 13:53, Andrew Haley wrote:
>> On 04/20/2015 10:03 AM, Andrew Dinn wrote:
>>> The following webrev is submitted for review (n.b. I am not an OpenJDK
>>> committer so the patch does not yet have an associated JIRA).
>>
>> The patch looks good to me.
>>
>> https://bugs.openjdk.java.net/browse/JDK-8078263
> 
> A new webrev with the commit in standard format (listing JIRA#, sumamry
> and reviewer) and placed at:
> 
>   http://cr.openjdk.java.net/~adinn/8078263/webrev.01/

I'm surprised this got past jcheck:


[jcheck 81464834db37 2014-06-05 14:03:52 -0700]

> Changeset: 8074:671ecf42ede2
> Author:    adinn
> Date:      2015-04-21 14:40
>
> 8078263 AARCH64: Volatile fields should be accessed with ldar and stlr
> Summary: ad file rules now generate load acquire and store release for volatile accesses
> Reviewed-by: aph

Incomplete comment: Missing bugid line
Incomplete comment: Missing reviewer attribution
Extraneous text in comment

transaction abort!
rollback completed