[aarch64-port-dev ] aarch64-port-dev ] aarch64-port-dev ] RFR (S) 8131682: C1 should use multibyte nops everywhere

Dean Long dean.long at oracle.com
Thu Aug 13 06:25:03 UTC 2015


OK, I pushed it for you.

dl

On 8/11/2015 2:27 AM, Aleksey Shipilev wrote:
> Hi Dean,
>
> Ah yes, since we now use MacroAssembler::align to produce the effective
> alignment, we can drop the platform-specific changes. ARM and PPC ports
> may rewire their own MacroAssemblers if there are potentially better nop
> sequences.
>
> New changeset:
>    http://cr.openjdk.java.net/~shade/8131682/8131682.changeset
>
> Tested it builds and runs with full JPRT.
>
> See the "Reviewed-by" line there. I think there are Reviewers there...
>
> Thanks,
> -Aleksey
>
> On 08/10/2015 10:57 PM, Dean wrote:
>> Did you get a Reviewer yet?
>>
>> dl
>>
>>
>> Dean <dean.long at oracle.com> wrote:
>>> I can sponsor this.  How about removing the ppc, aarch64, and sparc changes and making sure it still builds?
>>>
>>> dl
>>>
>>>
>>> Aleksey Shipilev <aleksey.shipilev at oracle.com> wrote:
>>>> On 07/29/2015 07:30 PM, Dean Long wrote:
>>>>> On 7/29/2015 7:01 AM, Aleksey Shipilev wrote:
>>>>>> On 07/27/2015 01:21 PM, Andrew Haley wrote:
>>>>>>> On 27/07/15 10:13, Aleksey Shipilev wrote:
>>>>>>>> Thanks Goetz! Fixed the assembler_ppc.inline.hpp.
>>>>>>>>
>>>>>>>> Andrew/Edward, are you OK with AArch64 part?
>>>>>>>>     http://cr.openjdk.java.net/~shade/8131682/webrev.02/
>>>>>>> I agree that it looks good.
>>>>>> So, we have reviews from Dean Long, Goetz Lindenmaier, Andrew Dinn, and
>>>>>> Andrew Haley. Still no Capital (R)eviewers.
>>>>>>
>>>>>> Otherwise, I think we are good to go. I respinned the JPRT with
>>>>>> open+closed sources, and it would seem the changes in closed sources are
>>>>>> not required.
>>>>> The changes to sparc and ppc may not be required anymore.
>>>> Excellent, please sponsor!
>>>>   http://cr.openjdk.java.net/~shade/8131682/8131682.changeset
>>>>
>>>> Thanks,
>>>> -Aleksey
>>>>
>>>>
>



More information about the aarch64-port-dev mailing list