[aarch64-port-dev ] RFR: 8131362: aarch64: C2 does not handle large stack offsets

Andrew Haley aph at redhat.com
Fri Jul 17 09:01:17 UTC 2015


On 17/07/15 09:52, Edward Nevill wrote:
>> > Should it be +8 instead of +4? Or these offsets are not in bytes?:
>> > 
>> > +      unspill(rscratch1, true, src_offset);
>> > +      spill(rscratch1, true, dst_offset);
>> > +      unspill(rscratch1, true, src_offset+4);
>> > +      spill(rscratch1, true, dst_offset+4);
> Ouch! Good catch.
> 
> New webrev.
> 
> http://cr.openjdk.java.net/~enevill/8131362/webrev.03/

I'm a bit more concerned that this did not fail in testing.  I guess
there were no tests at all for stack-stack spills.

Andrew.



More information about the aarch64-port-dev mailing list