[aarch64-port-dev ] [9] RFR(S): 8130309: need to bailout cleanly if CompiledStaticCall::emit_to_interp_stub fails when codecache is out of space

Andrew Dinn adinn at redhat.com
Wed Jul 22 07:47:06 UTC 2015


Hi Thomas,

The patch looks good so it could be pushed as is as far as I am
concerned (*not* a hotspot/openjdk reviewer).

However, note that the ppc port also suffers from the same problem. It
employs an identical routine emit_trampoline_stub defined in the Arch
Description file (ppc.ad). You might want to include a tweak to the ppc
code as part of this fix or maybe leave it to Volker/Goetz et al.

n.b. the problem also affects both the ppc jdk8 code but is not present
in AArch64 jdk8. Since the ppc fix probably needs a backport it might be
better to leave that fix as a separate step?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in UK and Wales under Company Registration No. 3798903
Directors: Michael Cunningham (USA), Matt Parson (USA), Charlie Peters
(USA), Michael O'Neill (Ireland)


More information about the aarch64-port-dev mailing list