[aarch64-port-dev ] [9] RFR(S): 8130309: need to bailout cleanly if CompiledStaticCall::emit_to_interp_stub fails when codecache is out of space

[Dean Long]

On 7/24/2015 1:34 PM, Dean Long wrote:
> On 7/24/2015 4:29 AM, Tobias Hartmann wrote:
>> Hi Roland,
>>
>> thanks for the review!
>>
>> On 23.07.2015 15:51, Roland Westrelin wrote:
>>> assembler.cpp
>>>
>>> 68 Compile::current()->env()->record_failure("CodeCache is full”);
>>>
>>> That assumes we are calling this from c2 but it can be called from 
>>> c1 as well.
>> You are right. I moved this code to the C2 methods calling 
>> 'AbstractAssembler::start_a_stub()'. The corresponding C1 methods 
>> already contain a call to 'bailout()'.
>
> In the new webrev, aarch64 emit_trampoline_stub still calls 
> Compile::current()->env()->record_failure,
> and it appears that emit_trampoline_stub can be called from C1. 
> Shouldn't we fix it so that
> ciEnv::record_failure works correctly from C1?  Why does C1 need a 
> different bailout message?
>
> dl

I went ahead and file a separate RFE for the bailout issue: 
https://bugs.openjdk.java.net/browse/JDK-8132354

dl